Add ignore param to save_hyperparameters #6056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
Borda,
SeanNaren,
awaelchli,
carmocca,
justusschock,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6056 +/- ##
======================================
- Coverage 91% 91% -0%
======================================
Files 160 160
Lines 11423 11430 +7
======================================
- Hits 10434 10412 -22
- Misses 989 1018 +29 |
carmocca
reviewed
Feb 18, 2021
Borda
previously requested changes
Feb 18, 2021
| ignore = [ignore] | ||
| if isinstance(ignore, list): | ||
| ignore = [arg for arg in ignore if isinstance(arg, str)] | ||
| init_args = {k: v for k, v in init_args.items() if k not in ignore} |
Collaborator
There was a problem hiding this comment.
how about if ignore=None from default?
1 not in None <- TypeError: argument of type 'NoneType' is not iterable
Contributor
Author
There was a problem hiding this comment.
@Borda: I am doing a check for if ignore, if it's None, init_args won't be changed.
Contributor
Author
There was a problem hiding this comment.
And also the other tests will fail, as the default is None :)
SkafteNicki
reviewed
Feb 18, 2021
Co-authored-by: Nicki Skafte <[email protected]>
Co-authored-by: Nicki Skafte <[email protected]>
|
Hello @kaushikb11! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-22 11:07:25 UTC |
Co-authored-by: Nicki Skafte <[email protected]>
carmocca
approved these changes
Feb 18, 2021
rohitgr7
reviewed
Feb 18, 2021
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
rohitgr7
approved these changes
Feb 18, 2021
awaelchli
reviewed
Feb 19, 2021
Contributor
Author
|
@Borda Your requested change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
ignoreparam tosave_hyperparametersFixes #6003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃