Skip to content

Conversation

@edenlightning
Copy link
Contributor

@edenlightning edenlightning commented Feb 17, 2021

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Feb 17, 2021

Hello @edenlightning! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-18 13:26:52 UTC

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #6041 (507fa5c) into master (115e58a) will increase coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6041    +/-   ##
=======================================
+ Coverage      91%     93%    +2%     
=======================================
  Files         160     160            
  Lines       11407   11407            
=======================================
+ Hits        10408   10626   +218     
+ Misses        999     781   -218     

@Borda Borda added the docs Documentation related label Feb 17, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Co-authored-by: chaton <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
@tchaton tchaton marked this pull request as ready for review February 17, 2021 23:17
@edenlightning
Copy link
Contributor Author

@Borda please fix carlos comments

@Borda Borda added the ready PRs ready to be merged label Feb 18, 2021
@Borda Borda requested a review from carmocca February 18, 2021 10:55
@SeanNaren SeanNaren enabled auto-merge (squash) February 18, 2021 12:20
@carmocca carmocca disabled auto-merge February 18, 2021 12:56
@carmocca carmocca changed the title docs for prun + quantization Docs for Pruning, Quantization, and SWA Feb 18, 2021
@carmocca
Copy link
Contributor

This could be changed to

- inference
    - predict
    - model_compression
        - pruning
        - quantization
     - export
        - jit/torchscript
        - onnx

But probably in a different PR
cc: @edenafek

@carmocca carmocca enabled auto-merge (squash) February 18, 2021 13:30
@carmocca carmocca merged commit 3449e2d into master Feb 18, 2021
@carmocca carmocca deleted the docs/eden branch February 18, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants