rename accelerator_backend -> accelerator #6034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
Borda,
SeanNaren,
carmocca,
justusschock,
tchaton and
williamFalcon
as code owners
Borda
reviewed
Feb 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #6034 +/- ##
=======================================
- Coverage 93% 91% -3%
=======================================
Files 160 160
Lines 11403 11288 -115
=======================================
- Hits 10652 10229 -423
- Misses 751 1059 +308 |
11 tasks
justusschock
approved these changes
Feb 17, 2021
Member
justusschock
left a comment
justusschock
left a comment
There was a problem hiding this comment.
Like it. Please just add the property for backwards compatibility
SeanNaren
approved these changes
Feb 17, 2021
Contributor
SeanNaren
left a comment
SeanNaren
left a comment
There was a problem hiding this comment.
I love this, was one of my first confusions when dealing with lightning :)
Contributor
Author
|
@justusschock 👍 It is already there, from the accelerator refactor. |
carmocca
approved these changes
Feb 17, 2021
s-rog
approved these changes
Feb 18, 2021
Collaborator
|
@tchaton mind review? |
# Conflicts: # tests/core/test_datamodules.py # tests/models/test_hooks.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #5743
Shorter, cleaner. There is no confusion that we are using the accelerator.
It's backward compatible, we have a property that redirects accelerator_backend to accelerator :)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃