-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix flake8 for new plugins #5951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seems some tests are failing... |
Codecov Report
@@ Coverage Diff @@
## master #5951 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 160 160
Lines 11403 11400 -3
======================================
- Hits 10652 10621 -31
- Misses 751 779 +28 |
0f409f6 to
935d9d6
Compare
935d9d6 to
97c9288
Compare
| """ | ||
| return self.training_type_plugin.validation_step_end(output) | ||
|
|
||
| def predict(self, args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchaton we had multiple declarations of this method inside a single class and after removing the second one TPU tests are failing... mind have look at it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will
97c9288 to
8bdbccb
Compare
c5e5785 to
5209f47
Compare
|
@awaelchli any idea why TPU is failing? |
What does this PR do?
Follow up to #5743
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃