Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 13, 2021

What does this PR do?

Follow up to #5743

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda
Copy link
Collaborator

Borda commented Feb 13, 2021

Seems some tests are failing...

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #5951 (b50c763) into master (02ac4b0) will decrease coverage by 0%.
The diff coverage is 97%.

@@          Coverage Diff           @@
##           master   #5951   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         160     160           
  Lines       11403   11400    -3     
======================================
- Hits        10652   10621   -31     
- Misses        751     779   +28     

@Borda Borda enabled auto-merge (squash) February 14, 2021 09:38
@Borda Borda added this to the 1.2 milestone Feb 14, 2021
@Borda Borda added the ready PRs ready to be merged label Feb 14, 2021
@Borda Borda force-pushed the refactor/flake8-plugins branch from 0f409f6 to 935d9d6 Compare February 16, 2021 20:58
@Borda Borda force-pushed the refactor/flake8-plugins branch from 935d9d6 to 97c9288 Compare February 16, 2021 22:50
@mergify mergify bot removed the has conflicts label Feb 16, 2021
"""
return self.training_type_plugin.validation_step_end(output)

def predict(self, args):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaton we had multiple declarations of this method inside a single class and after removing the second one TPU tests are failing... mind have look at it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will

@Borda Borda added priority: 0 High priority task bug Something isn't working labels Feb 16, 2021
@Borda Borda force-pushed the refactor/flake8-plugins branch from 97c9288 to 8bdbccb Compare February 17, 2021 07:22
@Borda Borda force-pushed the refactor/flake8-plugins branch from c5e5785 to 5209f47 Compare February 17, 2021 19:51
@Borda Borda mentioned this pull request Feb 17, 2021
11 tasks
@mergify mergify bot removed the has conflicts label Feb 18, 2021
@Borda
Copy link
Collaborator

Borda commented Feb 18, 2021

@awaelchli any idea why TPU is failing?
cc: @tchaton

@mergify mergify bot removed the has conflicts label Feb 18, 2021
@Borda Borda merged commit fc9bb53 into master Feb 18, 2021
@Borda Borda deleted the refactor/flake8-plugins branch February 18, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: 0 High priority task ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants