-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Makefile: Refer to CONTRIBUTING doc, reword test to avoid "example"
#5910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: Refer to CONTRIBUTING doc, reword test to avoid "example"
#5910
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5910 +/- ##
========================================
- Coverage 88% 46% -42%
========================================
Files 170 170
Lines 11805 11648 -157
========================================
- Hits 10399 5336 -5063
- Misses 1406 6312 +4906 |
Makefile
Outdated
|
|
||
| # specific file | ||
| # python -m coverage run --source pytorch_lightning -m pytest --flake8 --durations=0 -v -k | ||
| # example for specific file/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we do not need it here makefile anymore...
just if it is missing add it to the contribution guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! There's already a mention of how to do this in the section for adding a new test, but I've also added a concrete example for an existing test.
|
@EricCousineau-TRI thank you for sending your PR, just a minor issue coming from our side... we have swapped branches regarding upcoming feat 1.2, mind rebase on actual |
|
Sounds good! I'll wait for #5909 to land before rebasing. |
hi @EricCousineau-TRI your mentioned PR is merged, let's get this done too :] |
CONTRIBUTING: Add concrete example for running single test
f91990c to
729cb99
Compare
test to avoid "example"
|
Done! |
What does this PR do?
Provides concrete example of running a single file, as is shown in other docs.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Yayyyy! 🎿