fixing miss-leading tested acc values

[Borda]

What does this PR do?

for some reason there were acc tested as loss for Boring models which does not make any sense and also leads to random failers...

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified
• Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #5876 (08d3b12) into master (ebabe56) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5876   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         160     160           
  Lines       11435   11435           
======================================
- Hits        10690   10683    -7     
- Misses        745     752    +7     

[Borda]

@rohitgr7 mind checks why these tests are failing, not sure how it happens that the predictions are negative...

[rohitgr7]

@Borda can we do it separately for accelerators and trainer since only those two modules are left? After that, we can remove the unused code (related to EvalModelTemplate) once everything is done. Will try to get some time by this weekend and complete them. Can we close this for now?

[rohitgr7]

getting this error here:

RuntimeError: CUDA error: all CUDA-capable devices are busy or unavailable

aren't all the jobs on azure running independently?? @Borda
or something else is causing this error?

[Borda]

aren't all the jobs on azure running independently?

yes it should, each shall use own machine

[rohitgr7]

pls do a re-review. Changed/Updated a few things here.

[Borda]

pls do a re-review. Changed/Updated a few things here.

GREAT, Thank you!