Skip to content

accelerator refactor - fix memory issue with ddp_spawn #5855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

accelerator refactor - fix memory issue with ddp_spawn #5855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pytorch_lightning/accelerators/gpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ def setup(self, trainer, model):
raise MisconfigurationException(f"Device should be GPU, got {self.root_device} instead")
self.set_nvidia_flags()
torch.cuda.set_device(self.root_device)
model.to(self.root_device)
return super().setup(trainer, model)

Copy link
Contributor Author

@awaelchli awaelchli Feb 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to double check here with @tchaton and @justusschock
is it good to remove this? any implications for rpc/sequential?
For the other plugins I have not seen anything breaking.

Copy link
Member

@justusschock justusschock Feb 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine

def on_train_start(self):
Expand Down
2 changes: 2 additions & 0 deletions pytorch_lightning/plugins/training_type/dp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ def __init__(self, parallel_devices: List[torch.device]):
super().__init__(parallel_devices=parallel_devices, cluster_environment=None)

def setup(self, model):
# model needs to be moved to the device before it is wrapped
model.to(self.root_device)
self._model = DataParallel(LightningParallelModule(model), self.parallel_devices)

def reduce(self, output, *args, **kwargs):
Expand Down