Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Remove tests in legacy folder that cannot pass anymore after the refactor.
These tests were moved and adapted in #5743.
This PR should be merged immediately before #5743

cc @justusschock @Borda

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli changed the title remove tests that cannot pass accelerator refactor - remove tests that cannot pass Feb 6, 2021
@awaelchli awaelchli changed the title accelerator refactor - remove tests that cannot pass accelerator refactor - remove legacy tests that cannot pass Feb 6, 2021
@awaelchli awaelchli added this to the 1.2 milestone Feb 6, 2021
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #5849 (b5e1f6a) into release/1.2-dev (4d2b13f) will decrease coverage by 0%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.2-dev   #5849    +/-   ##
================================================
- Coverage               88%     88%    -0%     
================================================
  Files                  181     181            
  Lines                12928   12759   -169     
================================================
- Hits                 11426   11229   -197     
- Misses                1502    1530    +28     

@awaelchli awaelchli mentioned this pull request Feb 6, 2021
16 tasks
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some conflicts to resolve :)

Base automatically changed from release/1.2-dev to master February 11, 2021 14:32
@awaelchli awaelchli closed this Feb 12, 2021
@awaelchli awaelchli deleted the refactor/dead-legacy-tests branch February 14, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants