Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jan 30, 2021

What does this PR do?

apply yapf to metrics

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label Jan 30, 2021
@Borda Borda added this to the 1.2 milestone Jan 30, 2021
@pep8speaks
Copy link

pep8speaks commented Jan 30, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-31 08:54:10 UTC

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #5722 (f0c00c0) into release/1.2-dev (5d239cc) will increase coverage by 0%.
The diff coverage is 74%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5722   +/-   ##
===============================================
  Coverage               89%     89%           
===============================================
  Files                  169     169           
  Lines                12415   12415           
===============================================
+ Hits                 11099   11100    +1     
+ Misses                1316    1315    -1     

@Borda Borda added the ready PRs ready to be merged label Jan 31, 2021
@Borda Borda self-assigned this Jan 31, 2021
@Borda Borda enabled auto-merge (squash) January 31, 2021 12:42
@Borda Borda merged commit 963c17b into release/1.2-dev Feb 1, 2021
@Borda Borda deleted the yapf/metrics branch February 1, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants