Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jan 27, 2021

What does this PR do?

adding docker image based on nvcr.io/nvidia/pytorch
@edenlightning tested locally and works fine :]

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label Jan 27, 2021
@Borda Borda added this to the 1.2 milestone Jan 27, 2021
@Borda Borda requested a review from tchaton as a code owner January 27, 2021 00:12
@Borda Borda self-assigned this Jan 27, 2021
Copy link
Contributor

@s-rog s-rog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My env is a modified ngc pytorch image as well!

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #5668 (ede49cf) into release/1.2-dev (817a41d) will decrease coverage by 0%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.2-dev   #5668    +/-   ##
================================================
- Coverage               89%     89%    -0%     
================================================
  Files                  168     168            
  Lines                12423   12267   -156     
================================================
- Hits                 11102   10933   -169     
- Misses                1321    1334    +13     

@Borda Borda added the ready PRs ready to be merged label Jan 27, 2021
@SeanNaren
Copy link
Contributor

SeanNaren commented Jan 27, 2021

Nice to hear @s-rog, the provided NGC images are awesome and I've been using them religiously for a while now. Comes with awesome niceties like MPI support (since they build torch from source!).

Thanks @Borda!

Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't know much about docker but if @Borda says it works, it works. 😄

@Borda Borda enabled auto-merge (squash) January 27, 2021 10:40
@Borda
Copy link
Collaborator Author

Borda commented Jan 27, 2021

TBH I don't know much about docker but if @Borda says it works, it works. 😄

add test for it in CI :]

@Borda Borda requested a review from tchaton January 29, 2021 13:29
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit 07f24d2 into release/1.2-dev Jan 29, 2021
@Borda Borda deleted the docker/nvidia branch January 29, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants