-
Notifications
You must be signed in to change notification settings - Fork 3.6k
add NVIDIA docker image #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NVIDIA docker image #5668
Conversation
s-rog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My env is a modified ngc pytorch image as well!
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5668 +/- ##
================================================
- Coverage 89% 89% -0%
================================================
Files 168 168
Lines 12423 12267 -156
================================================
- Hits 11102 10933 -169
- Misses 1321 1334 +13 |
rohitgr7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't know much about docker but if @Borda says it works, it works. 😄
add test for it in CI :] |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
adding docker image based on
nvcr.io/nvidia/pytorch@edenlightning tested locally and works fine :]
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃