Skip to content

Conversation

@ydcjeff
Copy link

@ydcjeff ydcjeff commented Jan 15, 2021

What does this PR do?

Remove unused beta argument in precision/recall in docstring

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the docs Documentation related label Jan 15, 2021
@Borda Borda added this to the 1.1.x milestone Jan 15, 2021
@Borda Borda enabled auto-merge (squash) January 15, 2021 15:52
@Borda Borda added the ready PRs ready to be merged label Jan 15, 2021
@rohitgr7
Copy link
Contributor

some changes are made to Precision/recall here. #4842
can you check if it's still required? @ydcjeff

@Borda
Copy link
Collaborator

Borda commented Jan 15, 2021

some changes are made to Precision/recall here. #4842
can you check if it's still required? @ydcjeff

the main diff is that this goes to master as bug-fix, the other is for 1.2

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #5532 (7e7ce35) into master (c80e45d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5532   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         135     135           
  Lines       10007   10007           
======================================
  Hits         9341    9341           
  Misses        666     666           

@ydcjeff
Copy link
Author

ydcjeff commented Jan 15, 2021

some changes are made to Precision/recall here. #4842
can you check if it's still required? @ydcjeff

Yes, it has been removed from docstring in that. It can be said this can be closed.

@Borda Borda closed this Jan 15, 2021
auto-merge was automatically disabled January 15, 2021 17:51

Pull request was closed

@Borda Borda reopened this Jan 15, 2021
@Borda Borda enabled auto-merge (squash) January 15, 2021 17:52
@Borda Borda merged commit a56f745 into Lightning-AI:master Jan 18, 2021
@ydcjeff ydcjeff deleted the patch-1 branch January 18, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants