Skip to content

Conversation

@arnaudgelas
Copy link
Contributor

@arnaudgelas arnaudgelas commented Jan 15, 2021

What does this PR do?

Relates to #4805

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/utilities/*.py
@Borda Borda enabled auto-merge (squash) January 15, 2021 15:50
@Borda Borda added the ready PRs ready to be merged label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #5530 (84b585b) into release/1.2-dev (8629048) will not change coverage.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5530   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  152     152           
  Lines                10736   10736           
===============================================
  Hits                  9948    9948           
  Misses                 788     788           

rohitgr7
rohitgr7 previously approved these changes Jan 15, 2021
@rohitgr7 rohitgr7 disabled auto-merge January 15, 2021 17:21
@rohitgr7
Copy link
Contributor

docs checks are failing.. can you check?
https://github.com/PyTorchLightning/pytorch-lightning/pull/5530/checks?check_run_id=1709162903

@Borda
Copy link
Collaborator

Borda commented Jan 15, 2021

docs checks are failing.. can you check?
https://github.com/PyTorchLightning/pytorch-lightning/pull/5530/checks?check_run_id=1709162903

it seems to be unrelated as the template is missing and we have not touched it here...

  File "/github/workspace/docs/source/conf.py", line 22, in <module>
    import pt_lightning_sphinx_theme
ModuleNotFoundError: No module named 'pt_lightning_sphinx_theme'

@Borda Borda enabled auto-merge (squash) January 15, 2021 17:27
@Borda Borda requested review from rohitgr7 and s-rog January 15, 2021 17:27
@Borda Borda merged commit e4688ae into Lightning-AI:release/1.2-dev Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants