Skip to content

Conversation

@arnaudgelas
Copy link
Contributor

@arnaudgelas arnaudgelas commented Jan 13, 2021

What does this PR do?

Relates to #4805work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda enabled auto-merge (squash) January 15, 2021 08:13
@arnaudgelas arnaudgelas force-pushed the fix/isort-pl.accelerators branch from d26af73 to 4c92b31 Compare January 15, 2021 14:22
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #5503 (9faeaf6) into release/1.2-dev (2fe36c7) will decrease coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5503   +/-   ##
===============================================
- Coverage               93%     93%   -0%     
===============================================
  Files                  152     152           
  Lines                10736   10735    -1     
===============================================
- Hits                  9948    9947    -1     
  Misses                 788     788           

@Borda Borda added the refactor label Jan 15, 2021
@Borda Borda added this to the 1.2 milestone Jan 15, 2021
@Borda Borda added the ready PRs ready to be merged label Jan 15, 2021
@arnaudgelas arnaudgelas force-pushed the fix/isort-pl.accelerators branch from 4c92b31 to 94c464e Compare January 15, 2021 18:58
Remove from skipped module in pyproject.toml and fix failures on:
- pytorch_lightning/accelerators/*.py
@arnaudgelas arnaudgelas force-pushed the fix/isort-pl.accelerators branch from 2308d5e to 9faeaf6 Compare January 16, 2021 18:51
@Borda Borda merged commit 1ff6b18 into Lightning-AI:release/1.2-dev Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants