Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Jan 13, 2021

What does this PR do?

Fixes # (issue) <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #5500 (c0aabf4) into release/1.2-dev (51b9df3) will decrease coverage by 3%.
The diff coverage is 8%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5500    +/-   ##
================================================
- Coverage               93%     90%    -3%     
================================================
  Files                  151     152     +1     
  Lines                10617   11239   +622     
================================================
+ Hits                  9829   10090   +261     
- Misses                 788    1149   +361     

@stale
Copy link

stale bot commented Feb 2, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Feb 2, 2021
@stale
Copy link

stale bot commented Feb 7, 2021

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Feb 7, 2021
@Borda Borda deleted the rich_logging_2 branch April 23, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has conflicts won't fix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant