update tests with new auto_opt api #5466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
requested review from
Borda,
SeanNaren,
awaelchli,
justusschock,
tchaton and
williamFalcon
as code owners
justusschock
approved these changes
Jan 12, 2021
Member
justusschock
left a comment
justusschock
left a comment
There was a problem hiding this comment.
@rohitgr7 I added some suggestions, since the way you implemented it, you overwrite the property, but this way we just change the value used by the property.
| class TestModel(BoringModel): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| class TestModel(BoringModel): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| def __init__(self): | ||
| super().__init__() | ||
| self.sequential_module = nn.Sequential(torch.nn.Linear(32, 32), nn.ReLU(), nn.Linear(32, 2)) | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| class SequentialModelRPCAutomatic(SequentialModelRPCManual): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| class TestModel(BoringModel): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
|
|
||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| class TestModel(BoringModel): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| class TestModel(BoringModel): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| class TestModel(BoringModel): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
| class TestModel(BoringModel): | ||
| def __init__(self): | ||
| super().__init__() | ||
| self.automatic_optimization = False |
Member
There was a problem hiding this comment.
Suggested change
| self.automatic_optimization = False | |
| self._automatic_optimization = False |
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #5466 +/- ##
========================================
+ Coverage 44% 93% +49%
========================================
Files 135 135
Lines 9875 10015 +140
========================================
+ Hits 4380 9338 +4958
+ Misses 5495 677 -4818 |
carmocca
approved these changes
Jan 12, 2021
rohitgr7
commented
Jan 12, 2021
Borda
added a commit
that referenced
this pull request
Feb 4, 2021
* update tests with new auto_opt api * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updates tests missed here #5169
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃