Skip to content

Conversation

@arnaudgelas
Copy link
Contributor

@arnaudgelas arnaudgelas commented Jan 8, 2021

What does this PR do?

Relates to #4805

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda enabled auto-merge (squash) January 11, 2021 12:25
@Borda Borda added ready PRs ready to be merged and removed ready PRs ready to be merged labels Jan 11, 2021
@Borda
Copy link
Collaborator

Borda commented Jan 11, 2021

@arnaudgelas remove the folder from skip list...

@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.backends branch from 11e0578 to b2ceb95 Compare January 11, 2021 14:11
@arnaudgelas arnaudgelas disabled auto-merge January 11, 2021 14:23
@Borda Borda enabled auto-merge (squash) January 11, 2021 14:30
@Borda Borda added the ready PRs ready to be merged label Jan 11, 2021
@Borda Borda mentioned this pull request Jan 12, 2021
30 tasks
@Borda
Copy link
Collaborator

Borda commented Jan 13, 2021

@arnaudgelas mind resolve conflicts 🐰

@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.backends branch from b2ceb95 to 9e693e7 Compare January 13, 2021 18:34
@arnaudgelas
Copy link
Contributor Author

@Borda rebased

@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.backends branch from 9e693e7 to 5358ec9 Compare January 14, 2021 08:26
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #5430 (9a781a2) into release/1.2-dev (ddd9cc1) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2-dev   #5430   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  152     152           
  Lines                10736   10736           
===============================================
  Hits                  9948    9948           
  Misses                 788     788           

@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.backends branch from 5358ec9 to e22f707 Compare January 14, 2021 11:17
@Borda Borda mentioned this pull request Jan 14, 2021
12 tasks
@arnaudgelas arnaudgelas force-pushed the fix/isort-tests.backends branch from e22f707 to d7feb7e Compare January 14, 2021 13:30
@Borda Borda merged commit 7523e69 into Lightning-AI:release/1.2-dev Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants