-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix pre-commit isort failure on tests/backends/*.py #5430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Borda
merged 5 commits into
Lightning-AI:release/1.2-dev
from
arnaudgelas:fix/isort-tests.backends
Jan 15, 2021
Merged
Fix pre-commit isort failure on tests/backends/*.py #5430
Borda
merged 5 commits into
Lightning-AI:release/1.2-dev
from
arnaudgelas:fix/isort-tests.backends
Jan 15, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
approved these changes
Jan 11, 2021
justusschock
approved these changes
Jan 11, 2021
Collaborator
|
@arnaudgelas remove the folder from skip list... |
11e0578 to
b2ceb95
Compare
Borda
approved these changes
Jan 11, 2021
akihironitta
approved these changes
Jan 12, 2021
Collaborator
|
@arnaudgelas mind resolve conflicts 🐰 |
b2ceb95 to
9e693e7
Compare
Contributor
Author
|
@Borda rebased |
9e693e7 to
5358ec9
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5430 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 152 152
Lines 10736 10736
===============================================
Hits 9948 9948
Misses 788 788 |
5358ec9 to
e22f707
Compare
12 tasks
e22f707 to
d7feb7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Relates to #4805
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃