Enforce pre-commit to use a recent and fixed version of isort. #5408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudgelas
requested review from
Borda,
SeanNaren,
awaelchli,
justusschock,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5408 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 150 150
Lines 10490 10490
===============================================
Hits 9719 9719
Misses 771 771 |
carmocca
reviewed
Jan 7, 2021
carmocca
reviewed
Jan 7, 2021
Collaborator
|
@arnaudgelas pls keep in your PR the bullet list for checking... |
Previously pre-commit was using any version of isort found on developer machine. Now, used isort is from the official repository and version is set to 5.7.0 (which is nowadays the latest release). Co-authored-by: Akihiro Nitta <[email protected]>
arnaudgelas
force-pushed
the
fix/pre-commit-isort-config
branch
from
0fcd381 to
d2ffe99
Compare
30 tasks
Contributor
Author
|
@Borda I have added back the checklist |
carmocca
approved these changes
Jan 8, 2021
justusschock
approved these changes
Jan 8, 2021
Borda
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Relates to #4805
Enforce pre-commit to use a recent and fixed version of isort rather than an uncontrolled one.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding upside_down_face