Skip to content

Fix pre-commit isort hook failure for benchmarks subdir. #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix pre-commit isort hook failure for benchmarks subdir. #5400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/generate_comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
import os

import matplotlib.pylab as plt
import pandas as pd

import pandas as pd
from benchmarks.test_basic_parity import measure_loops
from tests.base.models import ParityModuleMNIST, ParityModuleRNN

Expand Down
2 changes: 1 addition & 1 deletion benchmarks/test_basic_parity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

import numpy as np
import pytest
import torch
from tqdm import tqdm

import torch
Copy link
Collaborator

@Borda Borda Jan 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct as torch is external lib?

from pytorch_lightning import LightningModule, seed_everything, Trainer
from tests.base.models import ParityModuleMNIST, ParityModuleRNN

Expand Down
2 changes: 1 addition & 1 deletion benchmarks/test_sharded_parity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
from typing import Type, Union

import pytest
import torch

import torch
from pytorch_lightning import seed_everything, Trainer
from pytorch_lightning.plugins.ddp_plugin import DDPPlugin
from pytorch_lightning.plugins.sharded_plugin import DDPShardedPlugin
Expand Down