Fix pre-commit fix for isort for benchmark folder. #5397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudgelas
requested review from
Borda,
SeanNaren,
awaelchli,
edenlightning,
justusschock,
tchaton and
williamFalcon
as code owners
Borda
previously approved these changes
Jan 7, 2021
Collaborator
|
mind do the isort for benchmarks here? |
Borda
changed the title
Contributor
Author
|
@Borda I am confused. I am opening PRs to be merged onto release/1.2-dev, but you also want me to open PRs to be merged onto master. Is that correct? |
Collaborator
all import/isort fixes shall go to 1.2 (here it was just reopened as stated isort and for each PR we can change target any time later, just it may contain collisions so I was thinking about using it...) |
Borda
force-pushed
the
fix/pre-commit-failures
branch
from
1b11681 to
f917be8
Compare
Collaborator
|
closing in favor #5400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @Borda 's input, here is the fix for isort for benchmark folder.