Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jan 6, 2021

What does this PR do?

it was broken already for a while but somehow it has not appeared till yesterday after some other libs update
the very same fix I have done already in #5365

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working example priority: 1 Medium priority task labels Jan 6, 2021
@Borda Borda added this to the 1.2 milestone Jan 6, 2021
@carmocca
Copy link
Contributor

carmocca commented Jan 6, 2021

shouldn't this target master instead of release?

@Borda Borda requested a review from justusschock January 6, 2021 09:32
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #5375 (21c0484) into release/1.2-dev (3c6e06b) will increase coverage by 4%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.2-dev   #5375    +/-   ##
================================================
+ Coverage               89%     93%    +4%     
================================================
  Files                  146     146            
  Lines                10361   10361            
================================================
+ Hits                  9220    9597   +377     
+ Misses                1141     764   -377     

@Borda Borda enabled auto-merge (squash) January 6, 2021 12:42
@Borda Borda added the ready PRs ready to be merged label Jan 6, 2021
Borda and others added 2 commits January 7, 2021 00:58
@Borda Borda force-pushed the bugfix/example-win-loader branch from b5e9fd3 to 21c0484 Compare January 6, 2021 23:59
@Borda Borda merged commit 8a40e80 into release/1.2-dev Jan 7, 2021
@Borda Borda deleted the bugfix/example-win-loader branch January 7, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working example priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants