-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add LambdaCallback #5347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SkafteNicki
merged 44 commits into
Lightning-AI:release/1.2-dev
from
archsyscall:feature/lambdacallback
Jan 13, 2021
Merged
Add LambdaCallback #5347
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
0df6bd9
Add LambdaCallback
archsyscall aa13ddf
docs
archsyscall 01bd0a5
add pr link
Borda b0953dd
convention
archsyscall 7863e67
Fix Callback Typo
archsyscall 6792408
Update pytorch_lightning/callbacks/lambda_cb.py
archsyscall d934a23
Update pytorch_lightning/callbacks/lambda_cb.py
archsyscall 9fc981a
Update pytorch_lightning/callbacks/lambda_cb.py
archsyscall a93e468
use Misconfigureation
archsyscall 2ef199f
update docs
archsyscall cb294e0
sort export
archsyscall aadde9e
use inspect
archsyscall 8c10b14
string fill
archsyscall 39b1970
use fast dev run
archsyscall dc11767
isort
archsyscall 0cfef59
remove unused import
archsyscall 6835771
sort
archsyscall 0263e3a
hilightning
archsyscall 7249a10
highlighting
archsyscall 3038d2f
highlighting
archsyscall c400b98
remove debug log
archsyscall 8518382
eq
archsyscall 8bfe53e
res
archsyscall 9fd4c6b
results
archsyscall c4563c7
add misconfig exception test
archsyscall a329d4a
use pytest raises
archsyscall 571b941
Merge remote-tracking branch 'upstream/release/1.2-dev' into feature/…
archsyscall d1f8d4a
fix
archsyscall 7293115
Apply suggestions from code review
Borda 4d85f59
Update pytorch_lightning/callbacks/lambda_cb.py
archsyscall c9ecb8a
hc
archsyscall 2044291
rm pt
archsyscall 5359ce6
Merge branch 'release/1.2-dev' into feature/lambdacallback
tchaton 556ea09
fix
archsyscall d190e15
try fix
rohitgr7 d7bfc4a
Merge branch 'release/1.2-dev' into feature/lambdacallback
rohitgr7 a27dbff
whitespace
rohitgr7 d1bd19a
new hook
rohitgr7 afe018a
add raise
archsyscall 709fb5b
fix
archsyscall 9b93a2c
remove unused
archsyscall 72f3f0c
rename
archsyscall 7ed3eea
Merge branch 'release/1.2-dev' into feature/lambdacallback
SkafteNicki 2ce0131
Merge branch 'release/1.2-dev' into feature/lambdacallback
SkafteNicki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| # Copyright The PyTorch Lightning team. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| r""" | ||
| Lambda Callback | ||
| ^^^^^^^^^^^^^^^ | ||
|
|
||
| Create a simple callback on the fly using lambda functions. | ||
|
|
||
| """ | ||
|
|
||
| from typing import Callable, Optional | ||
|
|
||
| from pytorch_lightning.callbacks.base import Callback | ||
|
|
||
|
|
||
| class LambdaCallback(Callback): | ||
| r""" | ||
| Create a simple callback on the fly using lambda functions. | ||
|
|
||
| Args: | ||
| **kwargs: hooks supported by :class:`~pytorch_lightning.callbacks.base.Callback` | ||
|
|
||
| Example:: | ||
|
|
||
| >>> from pytorch_lightning import Trainer | ||
| >>> from pytorch_lightning.callbacks import LambdaCallback | ||
| >>> trainer = Trainer(callbacks=[LambdaCallback(setup=lambda *args: print('setup'))]) | ||
| """ | ||
|
|
||
| def __init__( | ||
| self, | ||
| on_before_accelerator_backend_setup: Optional[Callable] = None, | ||
| setup: Optional[Callable] = None, | ||
| teardown: Optional[Callable] = None, | ||
| on_init_start: Optional[Callable] = None, | ||
| on_init_end: Optional[Callable] = None, | ||
| on_fit_start: Optional[Callable] = None, | ||
| on_fit_end: Optional[Callable] = None, | ||
| on_sanity_check_start: Optional[Callable] = None, | ||
| on_sanity_check_end: Optional[Callable] = None, | ||
| on_train_batch_start: Optional[Callable] = None, | ||
| on_train_batch_end: Optional[Callable] = None, | ||
| on_train_epoch_start: Optional[Callable] = None, | ||
| on_train_epoch_end: Optional[Callable] = None, | ||
| on_validation_epoch_start: Optional[Callable] = None, | ||
| on_validation_epoch_end: Optional[Callable] = None, | ||
| on_test_epoch_start: Optional[Callable] = None, | ||
| on_test_epoch_end: Optional[Callable] = None, | ||
| on_epoch_start: Optional[Callable] = None, | ||
| on_epoch_end: Optional[Callable] = None, | ||
| on_batch_start: Optional[Callable] = None, | ||
| on_validation_batch_start: Optional[Callable] = None, | ||
| on_validation_batch_end: Optional[Callable] = None, | ||
| on_test_batch_start: Optional[Callable] = None, | ||
| on_test_batch_end: Optional[Callable] = None, | ||
| on_batch_end: Optional[Callable] = None, | ||
| on_train_start: Optional[Callable] = None, | ||
| on_train_end: Optional[Callable] = None, | ||
| on_pretrain_routine_start: Optional[Callable] = None, | ||
| on_pretrain_routine_end: Optional[Callable] = None, | ||
| on_validation_start: Optional[Callable] = None, | ||
| on_validation_end: Optional[Callable] = None, | ||
| on_test_start: Optional[Callable] = None, | ||
| on_test_end: Optional[Callable] = None, | ||
| on_keyboard_interrupt: Optional[Callable] = None, | ||
| on_save_checkpoint: Optional[Callable] = None, | ||
| on_load_checkpoint: Optional[Callable] = None, | ||
| on_after_backward: Optional[Callable] = None, | ||
| on_before_zero_grad: Optional[Callable] = None, | ||
| ): | ||
| if on_before_accelerator_backend_setup is not None: | ||
| self.on_before_accelerator_backend_setup = on_before_accelerator_backend_setup | ||
| if setup is not None: | ||
| self.setup = setup | ||
| if teardown is not None: | ||
| self.teardown = teardown | ||
| if on_init_start is not None: | ||
| self.on_init_start = on_init_start | ||
| if on_init_end is not None: | ||
| self.on_init_end = on_init_end | ||
| if on_fit_start is not None: | ||
| self.on_fit_start = on_fit_start | ||
| if on_fit_end is not None: | ||
| self.on_fit_end = on_fit_end | ||
| if on_sanity_check_start is not None: | ||
| self.on_sanity_check_start = on_sanity_check_start | ||
| if on_sanity_check_end is not None: | ||
| self.on_sanity_check_end = on_sanity_check_end | ||
| if on_train_batch_start is not None: | ||
| self.on_train_batch_start = on_train_batch_start | ||
| if on_train_batch_end is not None: | ||
| self.on_train_batch_end = on_train_batch_end | ||
| if on_train_epoch_start is not None: | ||
| self.on_train_epoch_start = on_train_epoch_start | ||
| if on_train_epoch_end is not None: | ||
| self.on_train_epoch_end = on_train_epoch_end | ||
| if on_validation_epoch_start is not None: | ||
| self.on_validation_epoch_start = on_validation_epoch_start | ||
| if on_validation_epoch_end is not None: | ||
| self.on_validation_epoch_end = on_validation_epoch_end | ||
| if on_test_epoch_start is not None: | ||
| self.on_test_epoch_start = on_test_epoch_start | ||
| if on_test_epoch_end is not None: | ||
| self.on_test_epoch_end = on_test_epoch_end | ||
| if on_epoch_start is not None: | ||
| self.on_epoch_start = on_epoch_start | ||
| if on_epoch_end is not None: | ||
| self.on_epoch_end = on_epoch_end | ||
| if on_batch_start is not None: | ||
| self.on_batch_start = on_batch_start | ||
| if on_validation_batch_start is not None: | ||
| self.on_validation_batch_start = on_validation_batch_start | ||
| if on_validation_batch_end is not None: | ||
| self.on_validation_batch_end = on_validation_batch_end | ||
| if on_test_batch_start is not None: | ||
| self.on_test_batch_start = on_test_batch_start | ||
| if on_test_batch_end is not None: | ||
| self.on_test_batch_end = on_test_batch_end | ||
| if on_batch_end is not None: | ||
| self.on_batch_end = on_batch_end | ||
| if on_train_start is not None: | ||
| self.on_train_start = on_train_start | ||
| if on_train_end is not None: | ||
| self.on_train_end = on_train_end | ||
| if on_pretrain_routine_start is not None: | ||
| self.on_pretrain_routine_start = on_pretrain_routine_start | ||
| if on_pretrain_routine_end is not None: | ||
| self.on_pretrain_routine_end = on_pretrain_routine_end | ||
| if on_validation_start is not None: | ||
| self.on_validation_start = on_validation_start | ||
| if on_validation_end is not None: | ||
| self.on_validation_end = on_validation_end | ||
| if on_test_start is not None: | ||
| self.on_test_start = on_test_start | ||
| if on_test_end is not None: | ||
| self.on_test_end = on_test_end | ||
| if on_keyboard_interrupt is not None: | ||
| self.on_keyboard_interrupt = on_keyboard_interrupt | ||
| if on_save_checkpoint is not None: | ||
| self.on_save_checkpoint = on_save_checkpoint | ||
| if on_load_checkpoint is not None: | ||
| self.on_load_checkpoint = on_load_checkpoint | ||
| if on_after_backward is not None: | ||
| self.on_after_backward = on_after_backward | ||
| if on_before_zero_grad is not None: | ||
| self.on_before_zero_grad = on_before_zero_grad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Copyright The PyTorch Lightning team. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| import inspect | ||
|
|
||
| from pytorch_lightning import seed_everything, Trainer | ||
| from pytorch_lightning.callbacks import Callback, LambdaCallback | ||
| from tests.base.boring_model import BoringModel | ||
|
|
||
|
|
||
| def test_lambda_call(tmpdir): | ||
| seed_everything(42) | ||
|
|
||
| class CustomModel(BoringModel): | ||
| def on_train_epoch_start(self): | ||
| if self.current_epoch > 1: | ||
| raise KeyboardInterrupt | ||
|
|
||
| checker = set() | ||
| hooks = [m for m, _ in inspect.getmembers(Callback, predicate=inspect.isfunction)] | ||
| hooks_args = {h: (lambda x: lambda *args: checker.add(x))(h) for h in hooks} | ||
| hooks_args["on_save_checkpoint"] = (lambda x: lambda *args: [checker.add(x)])("on_save_checkpoint") | ||
|
|
||
| model = CustomModel() | ||
| trainer = Trainer( | ||
| default_root_dir=tmpdir, | ||
| max_epochs=1, | ||
| limit_train_batches=1, | ||
| limit_val_batches=1, | ||
| callbacks=[LambdaCallback(**hooks_args)], | ||
| ) | ||
| results = trainer.fit(model) | ||
| assert results | ||
|
|
||
| model = CustomModel() | ||
| ckpt_path = trainer.checkpoint_callback.best_model_path | ||
| trainer = Trainer( | ||
| default_root_dir=tmpdir, | ||
| max_epochs=3, | ||
| limit_train_batches=1, | ||
| limit_val_batches=1, | ||
| limit_test_batches=1, | ||
| resume_from_checkpoint=ckpt_path, | ||
| callbacks=[LambdaCallback(**hooks_args)], | ||
| ) | ||
| results = trainer.fit(model) | ||
| trainer.test(model) | ||
|
|
||
| assert results | ||
| assert checker == set(hooks) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.