mark todo exceptions

[Borda]

What does this PR do?

adding to-do notes for exceptions that shall be better specified and cleaning a few of them...

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes [if needed]?
• Did you write any new necessary tests [no need for typos, docs]?
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified
• Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #5320 (9b79d27) into release/1.2-dev (9dbdffc) will decrease coverage by 1%.
The diff coverage is 45%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5320    +/-   ##
================================================
- Coverage               93%     91%    -1%     
================================================
  Files                  146     146            
  Lines                10211   10430   +219     
================================================
+ Hits                  9486    9535    +49     
- Misses                 725     895   +170     

[carmocca]

Is there a CI test to check that new code does not introduce broad exception catching?

[Borda]

Is there a CI test to check that new code does not introduce broad exception catching?

that would be nice, but not sure which tool does it... @carmocca mind have look?

[carmocca]

Do we not run CodeFactor anymore?

[Borda]

Do we not run CodeFactor anymore?

we do run it, so you suggest to define it there?

[carmocca]

we do run it, so you suggest to define it there?

Mind linking where it is run, I can't to find it? If I'm not mistaken, it has a rule for "Broad Exception catching", so it should appear as a failing check.

[Borda]

Mind linking where it is run, I can't to find it?

it seems it is running only for master...

If I'm not mistaken, it has a rule for "Broad Exception catching", so it should appear as a failing check.

there is no such a setting, probably a different tool, I remember I saw it elsewhere...

[carmocca]

it seems it is running only for master...

Then we should change it to run on both master/release

I remember I saw it elsewhere...

Pylint should include it with this rule: https://pycodequ.al/docs/pylint-messages/w0703-broad-except.html

[Borda]

Then we should change it to run on both master/release

can you send a PR with such config, because codefactor does not have any setting, all are taken from repo YAML files

Pylint should include it with this rule: https://pycodequ.al/docs/pylint-messages/w0703-broad-except.html

We are using flake8 but this shall be included too

[Borda]

@tchaton @SeanNaren mind review? =)