Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Dec 27, 2020

What does this PR do?

cleaning python sections

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration refactor labels Dec 27, 2020
@Borda Borda added this to the 1.1.x milestone Dec 27, 2020
@Borda Borda requested a review from tchaton as a code owner December 27, 2020 20:44
@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #5281 (5dace57) into master (64163c2) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5281   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9950    9950           
======================================
  Hits         9261    9261           
  Misses        689     689           

@Borda Borda enabled auto-merge (squash) December 28, 2020 13:16
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up!

@Borda Borda added the ready PRs ready to be merged label Dec 29, 2020
@Borda Borda self-assigned this Dec 29, 2020
@Borda
Copy link
Collaborator Author

Borda commented Dec 29, 2020

@tchaton mind review?

@Borda Borda merged commit ab7512d into master Dec 31, 2020
@Borda Borda deleted the ci/gha-python branch December 31, 2020 16:24
Borda added a commit that referenced this pull request Jan 6, 2021
* refactor python in GH actions

* .
* .

(cherry picked from commit ab7512d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants