Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 23, 2020

What does this PR do?

This PR merge master in release/1.2-dev

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tchaton tchaton self-assigned this Dec 23, 2020
@tchaton tchaton added this to the 1.2 milestone Dec 23, 2020
@Borda Borda self-assigned this Dec 23, 2020
@Borda
Copy link
Collaborator

Borda commented Dec 23, 2020

well this will be very hard to review as it touches almost all codebase... the key will be getting all tests to pass

@tchaton tchaton closed this Dec 27, 2020
@tchaton tchaton deleted the release_update branch December 27, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants