Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Dec 20, 2020

What does this PR do?

Fixes #5173

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added the checkpointing Related to checkpointing label Dec 20, 2020
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Dec 20, 2020
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Dec 20, 2020

no @Borda, this doesn't resolve #4911. That's a different issue.

@rohitgr7 rohitgr7 requested a review from carmocca December 20, 2020 21:21
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #5209 (e6641db) into master (be3e870) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5209   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9933    9933           
======================================
  Hits         9247    9247           
  Misses        686     686           

@s-rog s-rog merged commit c8eda3f into master Dec 21, 2020
@rohitgr7 rohitgr7 deleted the warn/ckpt_dirpath_warning branch December 21, 2020 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checkpointing Related to checkpointing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why all files are deleted from model checkpoint directory when save_top_k=1?

4 participants