Skip to content

Conversation

@rohitgr7
Copy link
Contributor

What does this PR do?

Sourcerer is gone: sourcerer-io/sourcerer-app#632 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 requested a review from Borda December 17, 2020 12:46
@rohitgr7 rohitgr7 added the docs Documentation related label Dec 17, 2020
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Dec 17, 2020
@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #5172 (417d096) into master (88b55e4) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5172   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         134     134           
  Lines        9933    9933           
======================================
- Hits         9247    9240    -7     
- Misses        686     693    +7     

@Borda Borda added the ready PRs ready to be merged label Dec 18, 2020
@rohitgr7
Copy link
Contributor Author

@edenlightning @williamFalcon mind review?

@Borda Borda merged commit 618580b into master Dec 20, 2020
@Borda Borda deleted the rm_sourcerer branch December 20, 2020 07:50
Borda added a commit that referenced this pull request Dec 23, 2020
* Remove Sourcerer

* trigger

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Dec 29, 2020
* Remove Sourcerer

* trigger

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Jan 4, 2021
* Remove Sourcerer

* trigger

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Jan 4, 2021
* Remove Sourcerer

* trigger

Co-authored-by: Jirka Borovec <[email protected]>
Borda added a commit that referenced this pull request Jan 5, 2021
* Remove Sourcerer

* trigger

Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants