Skip to content

Fix hang in DDP HPC accelerators #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Fix hang in DDP HPC accelerators #5157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc569f4
Fix hang in DDP HPC accelerators
ananthsub Dec 16, 2020
67c2c60
Update CHANGELOG.md
ananthsub Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Do not warn when the `name` key is used in the `lr_scheduler` dict ([#5057](https://github.com/PyTorchLightning/pytorch-lightning/pull/5057))

- Fixed `DDPHPCAccelerator` hangs in DDP construction by calling `init_device` ([#5157](https://github.com/PyTorchLightning/pytorch-lightning/pull/5157))


## [1.1.0] - 2020-12-09
Expand Down
3 changes: 3 additions & 0 deletions pytorch_lightning/accelerators/ddp_cpu_hpc_accelerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,6 @@ def model_to_device(self, model, process_idx):
def get_device_ids(self):
device_ids = None
return device_ids

def init_device(self, process_idx):
pass
1 change: 1 addition & 0 deletions pytorch_lightning/accelerators/ddp_hpc_accelerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ def ddp_train(self, process_idx, model):
"""
# determine which process we are and world size
self.set_world_ranks(process_idx)
self.init_device(process_idx)

# toggle prog bar
if (self.trainer.node_rank != 0 or process_idx != 0) and self.trainer.progress_bar_callback is not None:
Expand Down