Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Dec 13, 2020

What does this PR do?

seem to be quite time-consuming since it is really not needed to install fairscale on TPU...

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration priority: 1 Medium priority task labels Dec 13, 2020
@Borda Borda added this to the 1.1.x milestone Dec 13, 2020
@Borda Borda marked this pull request as ready for review December 13, 2020 23:55
@Borda Borda requested a review from tchaton as a code owner December 13, 2020 23:55
@s-rog s-rog added the ready PRs ready to be merged label Dec 14, 2020
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #5113 (7497b33) into master (3910b28) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5113   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         134     134           
  Lines        9928    9928           
======================================
- Hits         9242    9235    -7     
- Misses        686     693    +7     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit e5569a9 into master Dec 17, 2020
@Borda Borda deleted the ci/tpu-drop-fairscale branch December 17, 2020 21:52
awaelchli pushed a commit that referenced this pull request Dec 18, 2020
* drop install FairScale for TPU

* typo

Co-authored-by: Roger Shieh <[email protected]>
Borda added a commit that referenced this pull request Dec 23, 2020
* drop install FairScale for TPU

* typo

Co-authored-by: Roger Shieh <[email protected]>
Borda added a commit that referenced this pull request Dec 29, 2020
* drop install FairScale for TPU

* typo

Co-authored-by: Roger Shieh <[email protected]>
Borda added a commit that referenced this pull request Jan 4, 2021
* drop install FairScale for TPU

* typo

Co-authored-by: Roger Shieh <[email protected]>
Borda added a commit that referenced this pull request Jan 4, 2021
* drop install FairScale for TPU

* typo

Co-authored-by: Roger Shieh <[email protected]>
Borda added a commit that referenced this pull request Jan 5, 2021
* drop install FairScale for TPU

* typo

Co-authored-by: Roger Shieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants