Skip to content

Conversation

@c00k1ez
Copy link
Contributor

@c00k1ez c00k1ez commented Dec 7, 2020

What does this PR do?

Small fix for documentation. Added experiment_key argument to online mode example for CometLogger.

Discussed this issue on slack.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #4997 (5bc9e17) into master (cb28f79) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4997   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         130     130           
  Lines        9547    9547           
======================================
  Hits         8871    8871           
  Misses        676     676           

@rohitgr7 rohitgr7 added the docs Documentation related label Dec 7, 2020
@rohitgr7 rohitgr7 added this to the 1.1 milestone Dec 7, 2020
@rohitgr7 rohitgr7 added the ready PRs ready to be merged label Dec 7, 2020
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@rohitgr7 rohitgr7 merged commit aeaa6b2 into Lightning-AI:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants