add LSF support

[ajtritt]

What does this PR do?

Add support for running PyTorch Lightning on systems managed by LSF.

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests?
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Always.

[SeanNaren]

Thanks!! Looks good, would you be able to confirm it works on your end here when you can?

[justusschock]

Is there a way to test this. I'm not fond to add anything to the Codename we cannot Test somehow in ci, since we are currently improving on that.

[ajtritt]

Is there a way to test this. I'm not fond to add anything to the Codename we cannot Test somehow in ci, since we are currently improving on that.

I think you would need access to a system that's managed by LSF. How does SLURM support get tested?

[pep8speaks]

Hello @ajtritt! Thanks for updating this PR.

• In the file pytorch_lightning/accelerators/ddp_hpc_accelerator.py:

Line 39:1: E302 expected 2 blank lines, found 0

• In the file pytorch_lightning/accelerators/nvidia_mixin.py:

Line 20:1: E302 expected 2 blank lines, found 1

• In the file pytorch_lightning/cluster_environments/lsf_environment.py:

Line 176:1: W391 blank line at end of file

Comment last updated at 2020-12-12 00:51:01 UTC

[ajtritt]

Will open a new PR

[Borda]

Will open a new PR

Any reason why this was closed? =)

[ajtritt]

Will open a new PR

Any reason why this was closed? =)

The final set of changes are more than the original PR stated. I could have edited the PR description, but that's a silent action and I didn't want the changes to be missed by reviewers.

[Borda]

I think it would be completely fine to edit the description, reset all reviews, and comment that you extend the scope :]