[docs] remove irrelevant docs in optimizer_step #4964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4964 +/- ##
======================================
Coverage 93% 93%
======================================
Files 130 130
Lines 9547 9547
======================================
Hits 8871 8871
Misses 676 676 |
rohitgr7
requested review from
Borda,
SkafteNicki,
awaelchli and
justusschock
rohitgr7
changed the title
Borda
approved these changes
Dec 6, 2020
SkafteNicki
approved these changes
Dec 6, 2020
ydcjeff
approved these changes
Dec 6, 2020
Contributor
|
@rohitgr7 Can you add some context in the PR description? |
Contributor
Author
|
@awaelchli done. |
awaelchli
approved these changes
Dec 6, 2020
justusschock
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor doc fix. I believe this is irrelevant now.
Checked the history, it was added here: #1493, when it was a part of
optimizer_stepalong withzero_grad, but now they are separated.