Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Dec 1, 2020

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Dec 1, 2020
@Borda Borda added this to the 1.1 milestone Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #4941 (40a816e) into master (a941f96) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4941   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         124     124           
  Lines        9320    9320           
======================================
  Hits         8640    8640           
  Misses        680     680           

@Borda Borda requested a review from tchaton December 1, 2020 23:29
@Borda Borda marked this pull request as ready for review December 2, 2020 00:35
@Borda Borda added 3rd party Related to a 3rd-party feature Is an improvement or enhancement working as intended Working as intended labels Dec 2, 2020
TEMP_PATH = os.path.join(PROJECT_ROOT, 'test_temp')

if PROJECT_ROOT not in os.getenv('PYTHONPATH', ""):
os.environ['PYTHONPATH'] = f'{PROJECT_ROOT}:{os.environ.get("PYTHONPATH", "")}'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

his we can probably drop the relative path to root for Horovod... :]

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work there !

@Borda Borda added the ready PRs ready to be merged label Dec 2, 2020
@SeanNaren SeanNaren merged commit add387c into master Dec 2, 2020
@SeanNaren SeanNaren deleted the refactor/ghost branch December 2, 2020 10:00
@Borda Borda mentioned this pull request Dec 2, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party Related to a 3rd-party ci Continuous Integration feature Is an improvement or enhancement ready PRs ready to be merged working as intended Working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants