Backend unit tests #4856
Merged
Backend unit tests #4856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom wrapper logic to live within the plugin/accelerators
# Conflicts: # pytorch_lightning/trainer/connectors/precision_connector.py # pytorch_lightning/utilities/__init__.py
# Conflicts: # pytorch_lightning/utilities/__init__.py # requirements/extra.txt
tchaton
reviewed
Nov 27, 2020
Co-authored-by: Jirka Borovec <[email protected]>
justusschock
approved these changes
Nov 27, 2020
awaelchli
approved these changes
Nov 27, 2020
Contributor
There was a problem hiding this comment.
the addition of the plugins LGTM, nice work @SeanNaren ! (I only looked at the code, don't have much time to test it on my machine sorry)
The only concern I have is about the testing, which adds 3mins (11 mins on master vs. 14 mins here) and I am not sure if the addition of the sharded feature justifies this overhead. Are my observations correct?
Not sure how feasible this is here, but I would suggest to target more granular unit testing that does not involve a full expensive training loop.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃