Skip to content

Initialize trainer with None in DDPAccelerator #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 8, 2020
Merged

Initialize trainer with None in DDPAccelerator #4847

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06b604a
Initialize trainer with None
maxjeblick Nov 25, 2020
463942a
Merge branch 'master' into master
SeanNaren Nov 25, 2020
4449612
Merge branch 'master' into master
tchaton Nov 30, 2020
ec2fbe5
Merge branch 'master' into master
tchaton Dec 3, 2020
c3beaed
Merge branch 'master' into master
tchaton Dec 3, 2020
3fe3cdd
Merge branch 'master' into master
edenlightning Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/accelerators/ddp_accelerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

class DDPAccelerator(Accelerator):

def __init__(self, trainer, cluster_environment=None, ddp_plugin=None):
def __init__(self, trainer=None, cluster_environment=None, ddp_plugin=None):
Copy link
Collaborator

@Borda Borda Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add typing?

"""
Runs training using DDP strategy on a single machine (manually, not via cluster start)

Expand Down