Replace lightning logo asset #4844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenlightning
requested review from
Borda,
SeanNaren,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
teddykoker
approved these changes
Nov 25, 2020
Contributor
Author
|
@teddykoker you are quick!! |
s-rog
approved these changes
Nov 25, 2020
awaelchli
approved these changes
Nov 25, 2020
ydcjeff
approved these changes
Nov 25, 2020
Borda
reviewed
Nov 25, 2020
Collaborator
Borda
left a comment
Borda
left a comment
There was a problem hiding this comment.
why are we removing also the other logos?
Borda
approved these changes
Nov 25, 2020
Contributor
Author
|
Because they arent used anywhere |
Codecov Report
@@ Coverage Diff @@
## master #4844 +/- ##
======================================
Coverage 93% 93%
======================================
Files 124 124
Lines 9302 9302
======================================
Hits 8615 8615
Misses 687 687 |
edenlightning
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4286
And remove unused assets.