Sharded Plugin 2/n: Allow ddp plugin to modify optimizer state saving #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
requested review from
Borda,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4675 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 8941 8949 +8
======================================
+ Hits 8311 8319 +8
Misses 630 630 |
ananthsub
reviewed
Nov 14, 2020
ananthsub
reviewed
Nov 14, 2020
ananthsub
reviewed
Nov 14, 2020
added 10 commits
November 14, 2020 22:55
SeanNaren
changed the title
justusschock
approved these changes
Nov 18, 2020
# Conflicts: # pytorch_lightning/plugins/ddp_plugin.py
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
…#4675) * Allow ddp plugin to modify optimizer state saving * Rely on the accelerator for optimizer states * Ensure we init the accelerator for the saving function * Better comment for optim state dump * Revert "Ensure we init the accelerator for the saving function" This reverts commit af65eff * Added accelerator check to initialize tuner before saving model checkpoint * Simplify comment * Revert "Added accelerator check to initialize tuner before saving model checkpoint" This reverts commit f9929c0 * Return single optimizer state to reduce duplication * Fixed docstring * Fixed typing * Fixed comment * Added CHANGELOG.md Co-authored-by: chaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ties to #4178
Allows custom ddp plugin access to saving optimizer state. This is required for optimizer state sharding as we need to consolidate the optimizer state from all processes before saving.
cc @ananthsub @awaelchli
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃