Skip to content

Increase parity to match logging refactor #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2020
Merged

Increase parity to match logging refactor #4651

merged 6 commits into from
Nov 14, 2020

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented Nov 13, 2020

What does this PR do?

As discussed with @tchaton current PRs may fail due to the logging refactor slowing down things a bit.

This slightly increases parity to not have them fail due to unrelated speed issues until the logging will be optimised.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@ydcjeff ydcjeff added the feature Is an improvement or enhancement label Nov 13, 2020
@ydcjeff ydcjeff added this to the 1.0.7 milestone Nov 13, 2020
@ydcjeff ydcjeff added the ready PRs ready to be merged label Nov 13, 2020
Borda
Borda approved these changes Nov 13, 2020
View reviewed changes
benchmarks/test_parity.py
@pytest.mark.parametrize('cls_model,max_diff', [
(ParityModuleRNN, 0.05),
(ParityModuleMNIST, 0.8)
(ParityModuleMNIST, 0.82)
Copy link
Collaborator

@Borda Borda Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(ParityModuleMNIST, 0.82)
(ParityModuleMNIST, 0.85)

cc: @tchaton

@codecov
Copy link

codecov bot commented Nov 13, 2020 •
edited
Loading

Codecov Report

Merging #4651 (a06b641) into master (fa88905) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4651   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         117     117           
  Lines        8914    8914           
======================================
- Hits         8283    8280    -3     
- Misses        631     634    +3

@Borda Borda modified the milestones: 1.0.7, 1.0.x Nov 13, 2020
@ydcjeff ydcjeff merged commit 144a5c9 into master Nov 14, 2020
@ydcjeff ydcjeff deleted the parity_logging branch November 14, 2020 04:03
@tchaton tchaton added the bug Something isn't working label Nov 17, 2020
@tchaton tchaton removed the bug Something isn't working label Nov 17, 2020
tchaton added a commit that referenced this pull request Nov 17, 2020
@justusschock @tchaton @Borda
Increase parity to match logging refactor (#4651)
f162f38 
Co-authored-by: Jeff Yang <[email protected]>
Co-authored-by: chaton <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
@justusschock @tchaton
@Borda @rohitgr7
Increase parity to match logging refactor (#4651)
7d01a4e 
Co-authored-by: Jeff Yang <[email protected]>
Co-authored-by: chaton <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@nateraw nateraw Awaiting requested review from nateraw

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+3 more reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@ydcjeff ydcjeff ydcjeff approved these changes

@s-rog s-rog s-rog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature Is an improvement or enhancement ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.0.x

Development

Successfully merging this pull request may close these issues.

7 participants

@justusschock @Borda @SkafteNicki @rohitgr7 @ydcjeff @s-rog @tchaton