Skip to content

Conversation

@s-rog
Copy link
Contributor

@s-rog s-rog commented Nov 10, 2020

What does this PR do?

Adds a minimum version for skimage in tests since old versions do not contain the needed metrics package

Trace (skimage 0.15.x)
================================================== ERRORS ==================================================
__________________________ ERROR collecting tests/metrics/regression/test_psnr.py __________________________
tests/metrics/regression/test_psnr.py:6: in <module>
    from skimage.metrics import peak_signal_noise_ratio
E   ModuleNotFoundError: No module named 'skimage.metrics'
__________________________ ERROR collecting tests/metrics/regression/test_psnr.py __________________________
ImportError while importing test module '/home/roger/pytorch-lightning-dev/tests/metrics/regression/test_psnr.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/conda/lib/python3.6/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/metrics/regression/test_psnr.py:6: in <module>
    from skimage.metrics import peak_signal_noise_ratio
E   ModuleNotFoundError: No module named 'skimage.metrics'
__________________________ ERROR collecting tests/metrics/regression/test_ssim.py __________________________
tests/metrics/regression/test_ssim.py:6: in <module>
    from skimage.metrics import structural_similarity
E   ModuleNotFoundError: No module named 'skimage.metrics'
__________________________ ERROR collecting tests/metrics/regression/test_ssim.py __________________________
ImportError while importing test module '/home/roger/pytorch-lightning-dev/tests/metrics/regression/test_ssim.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/conda/lib/python3.6/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/metrics/regression/test_ssim.py:6: in <module>
    from skimage.metrics import structural_similarity
E   ModuleNotFoundError: No module named 'skimage.metrics'

@s-rog s-rog added bug Something isn't working ci Continuous Integration labels Nov 10, 2020
@s-rog s-rog added this to the 1.0.x milestone Nov 10, 2020
@ydcjeff ydcjeff added the ready PRs ready to be merged label Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #4598 (3d1ae50) into master (30ad3e2) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4598   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         116     116           
  Lines        8854    8854           
======================================
- Hits         8247    8244    -3     
- Misses        607     610    +3     

@ydcjeff ydcjeff merged commit 11415fa into master Nov 10, 2020
@ydcjeff ydcjeff deleted the test_skimage_ver branch November 10, 2020 10:46
SeanNaren pushed a commit that referenced this pull request Nov 11, 2020
Co-authored-by: Nicki Skafte <[email protected]>
(cherry picked from commit 11415fa)
Borda pushed a commit that referenced this pull request Nov 11, 2020
Co-authored-by: Nicki Skafte <[email protected]>
(cherry picked from commit 11415fa)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants