Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Nov 9, 2020

What does this PR do?

Update mocking pkgs according to fix from Bolts Lightning-Universe/lightning-bolts#234

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added docs Documentation related ci Continuous Integration labels Nov 9, 2020
@Borda Borda added this to the 1.0.x milestone Nov 9, 2020
@Borda Borda requested a review from awaelchli November 9, 2020 16:28
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #4591 (fdeba70) into master (343d19f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4591   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         116     116           
  Lines        8858    8858           
======================================
  Hits         8253    8253           
  Misses        605     605           

@Borda Borda marked this pull request as ready for review November 9, 2020 23:51
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda added the ready PRs ready to be merged label Nov 10, 2020
@Borda Borda merged commit abf1d4b into master Nov 10, 2020
@Borda Borda deleted the docs/mock-tests branch November 10, 2020 13:57
SeanNaren pushed a commit that referenced this pull request Nov 11, 2020
* fix mock pkgs in docs

* sphinx

* CI

Co-authored-by: chaton <[email protected]>
(cherry picked from commit abf1d4b)
Borda added a commit that referenced this pull request Nov 11, 2020
* fix mock pkgs in docs

* sphinx

* CI

Co-authored-by: chaton <[email protected]>
(cherry picked from commit abf1d4b)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
* fix mock pkgs in docs

* sphinx

* CI

Co-authored-by: chaton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants