Adds shortcut for path to log #4573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamFalcon
requested review from
Borda,
SeanNaren,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton and
teddykoker
as code owners
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-08 16:30:30 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4573 +/- ##
=======================================
+ Coverage 91% 93% +3%
=======================================
Files 116 116
Lines 8816 8835 +19
=======================================
+ Hits 7984 8234 +250
+ Misses 832 601 -231 |
SeanNaren
pushed a commit
that referenced
this pull request
Nov 10, 2020
* added log_dir shortcut to trainer properties for writing logs * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut (cherry picked from commit 09a5169)
SeanNaren
pushed a commit
that referenced
this pull request
Nov 11, 2020
* added log_dir shortcut to trainer properties for writing logs * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut (cherry picked from commit 09a5169)
SeanNaren
pushed a commit
that referenced
this pull request
Nov 11, 2020
This reverts commit d06c0fa
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* added log_dir shortcut to trainer properties for writing logs * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut * added log_dir shortcut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shortcut for path to log