Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Nov 6, 2020

What does this PR do?

these tests have been not tested even we have written tests for them...

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added example ci Continuous Integration labels Nov 6, 2020
@Borda Borda added this to the 1.0.x milestone Nov 6, 2020
@Borda Borda mentioned this pull request Nov 6, 2020
7 tasks
@edenlightning edenlightning modified the milestones: 1.0.x, 1.0.7 Nov 10, 2020
@Borda Borda modified the milestones: 1.0.7, 1.0.x Nov 11, 2020
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR !

@edenlightning edenlightning modified the milestones: 1.0.x, 1.0.7 Nov 13, 2020
@Borda Borda modified the milestones: 1.0.7, 1.0.x Nov 13, 2020
@Borda Borda added the ready PRs ready to be merged label Nov 13, 2020
@Borda Borda removed the ready PRs ready to be merged label Nov 14, 2020
@Borda Borda changed the title test PL examples test PL examples [wip] Nov 14, 2020
@Borda Borda changed the title test PL examples [wip] test PL examples Nov 16, 2020
@Borda Borda mentioned this pull request Nov 16, 2020
@Borda Borda added ready PRs ready to be merged and removed ready PRs ready to be merged labels Nov 16, 2020
@Borda Borda requested review from SeanNaren and tchaton November 17, 2020 00:19
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4551 (052c6a6) into master (b8a1916) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4551   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         117     117           
  Lines        8937    8937           
======================================
  Hits         8304    8304           
  Misses        633     633           

@Borda Borda merged commit 9a5d40a into master Nov 17, 2020
@Borda Borda deleted the tests/examples branch November 17, 2020 18:35
tchaton pushed a commit that referenced this pull request Nov 17, 2020
* test PL examples

* minor formatting

* skip failing

* skip failing

* args

* mnist datamodule

* refactor tests

* refactor tests

* skip

* skip

* drop DM

* drop DM

Co-authored-by: Sean Naren <[email protected]>
Borda added a commit that referenced this pull request Nov 17, 2020
* test PL examples

* minor formatting

* skip failing

* skip failing

* args

* mnist datamodule

* refactor tests

* refactor tests

* skip

* skip

* drop DM

* drop DM

Co-authored-by: Sean Naren <[email protected]>
@Borda
Copy link
Collaborator Author

Borda commented Nov 18, 2020

the founding yield in #4694

rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
* test PL examples

* minor formatting

* skip failing

* skip failing

* args

* mnist datamodule

* refactor tests

* refactor tests

* skip

* skip

* drop DM

* drop DM

Co-authored-by: Sean Naren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration example

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants