-
Notifications
You must be signed in to change notification settings - Fork 3.6k
test PL examples #4551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
test PL examples #4551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
approved these changes
Nov 8, 2020
4993c38 to
8e2d2ff
Compare
tchaton
approved these changes
Nov 12, 2020
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR !
SeanNaren
approved these changes
Nov 14, 2020
Closed
26353c9 to
e1020f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4551 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 8937 8937
======================================
Hits 8304 8304
Misses 633 633 |
tchaton
pushed a commit
that referenced
this pull request
Nov 17, 2020
* test PL examples * minor formatting * skip failing * skip failing * args * mnist datamodule * refactor tests * refactor tests * skip * skip * drop DM * drop DM Co-authored-by: Sean Naren <[email protected]>
Borda
added a commit
that referenced
this pull request
Nov 17, 2020
* test PL examples * minor formatting * skip failing * skip failing * args * mnist datamodule * refactor tests * refactor tests * skip * skip * drop DM * drop DM Co-authored-by: Sean Naren <[email protected]>
Collaborator
Author
|
the founding yield in #4694 |
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* test PL examples * minor formatting * skip failing * skip failing * args * mnist datamodule * refactor tests * refactor tests * skip * skip * drop DM * drop DM Co-authored-by: Sean Naren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
these tests have been not tested even we have written tests for them...
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃