Skip to content

Conversation

@ydcjeff
Copy link

@ydcjeff ydcjeff commented Nov 6, 2020

What does this PR do?

Fixes failing pypi publish action on master
pypa/gh-action-pypi-publish#44

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@ydcjeff ydcjeff added bug Something isn't working ci Continuous Integration labels Nov 6, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #4548 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4548   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         116     116           
  Lines        8815    8815           
======================================
  Hits         8225    8225           
  Misses        590     590           

@Borda
Copy link
Collaborator

Borda commented Nov 6, 2020

just wondering isn't v1 takes always the last version from 1.x.y?

@SeanNaren SeanNaren merged commit f3dfb98 into master Nov 6, 2020
@SeanNaren SeanNaren deleted the ci/pypa branch November 6, 2020 10:48
@ydcjeff
Copy link
Author

ydcjeff commented Nov 6, 2020

just wondering isn't v1 takes always the last version from 1.x.y?

I also thought like that, but some does, some doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants