Skip to content

Conversation

@KevinMathewT
Copy link
Contributor

@KevinMathewT KevinMathewT commented Oct 31, 2020

What does this PR do?

Fixes documentation here about ReduceLROnPlateau

Fixes #4454

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #4459 into master will increase coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4459    +/-   ##
=======================================
+ Coverage      91%     93%    +2%     
=======================================
  Files         113     113            
  Lines        8396    8191   -205     
=======================================
- Hits         7654    7623    -31     
+ Misses        742     568   -174     

@williamFalcon williamFalcon merged commit b50dd12 into Lightning-AI:master Oct 31, 2020
@KevinMathewT KevinMathewT deleted the 4454 branch October 31, 2020 12:45
@ydcjeff ydcjeff added the docs Documentation related label Oct 31, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Oct 31, 2020
Borda pushed a commit that referenced this pull request Nov 4, 2020
(cherry picked from commit b50dd12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReduceLROnPlateau Scheduler documentation problem

3 participants