[docker] Lock cuda version #4453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydcjeff
requested review from
Borda,
SeanNaren,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4453 +/- ##
======================================
Coverage 93% 93%
======================================
Files 113 113
Lines 8191 8191
======================================
Hits 7623 7623
Misses 568 568 |
Borda
approved these changes
Oct 31, 2020
SeanNaren
approved these changes
Oct 31, 2020
SkafteNicki
approved these changes
Oct 31, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 4, 2020
* lock cuda version * back to normal (cherry picked from commit 1d594c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PyTorch 1.7 ships binaries with CUDA 11 by default, so apex is failed to install from source
Lock cuda=CUDA_VERSION in building dockers
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃