Skip to content

show progressbar only on progress_rank 0 on ddp_slurm #4437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2020
Merged

show progressbar only on progress_rank 0 on ddp_slurm #4437

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28a2a52
show progressbar only on progress_rank 0 on ddp_slurm
cool425589 Oct 30, 2020
c93154f
Merge branch 'master' into bugfix/slurm_ddp_progressbar
tchaton Nov 2, 2020
bb9e0e7
Merge branch 'master' into bugfix/slurm_ddp_progressbar
cool425589 Nov 4, 2020
80fcac4
Merge branch 'master' into bugfix/slurm_ddp_progressbar
awaelchli Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch_lightning/accelerators/ddp_slurm_accelerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def ddp_train(self, process_idx, model):
self.set_world_ranks(process_idx)

# toggle prog bar
if self.trainer.global_rank == 0 and self.trainer.progress_bar_callback is not None:
if self.trainer.global_rank != 0 and self.trainer.progress_bar_callback is not None:
self.trainer.progress_bar_callback.disable()

# set warning rank
Expand Down