Skip to content

update logging docs and decorators #4431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 1, 2020
Merged

update logging docs and decorators #4431

merged 14 commits into from
Dec 1, 2020

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 29, 2020

Fixes #4299

rohitgr7
rohitgr7 commented Oct 29, 2020
View reviewed changes
@rohitgr7 rohitgr7 changed the title update logging docs [docs] update logging docs Oct 29, 2020
@rohitgr7 rohitgr7 added docs Documentation related logger Related to the Loggers labels Oct 29, 2020
@rohitgr7 rohitgr7 added this to the 1.0.x milestone Oct 29, 2020
@codecov
Copy link

codecov bot commented Oct 29, 2020 •
edited
Loading

Codecov Report

Merging #4431 (6c0e832) into master (c2e6e68) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4431   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         122     122           
  Lines        9221    9225    +4     
======================================
+ Hits         8541    8545    +4     
  Misses        680     680

awaelchli
awaelchli reviewed Oct 29, 2020
View reviewed changes
@rohitgr7 rohitgr7 requested a review from awaelchli November 2, 2020 17:10
@edenlightning
Copy link
Contributor

edenlightning commented Nov 5, 2020

@tchaton take a look?

@rohitgr7 rohitgr7 changed the title [docs] update logging docs update logging docs and decorators Nov 10, 2020
@edenlightning edenlightning modified the milestones: 1.0.x, 1.0.7 Nov 10, 2020
@Borda Borda removed this from the 1.0.7 milestone Nov 11, 2020
@edenlightning edenlightning added this to the 1.0.7 milestone Nov 13, 2020
@Borda Borda modified the milestones: 1.0.7, 1.0.x Nov 13, 2020
tchaton
tchaton requested changes Nov 14, 2020
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rohitgr7. rank_zero_only is only for internal use and should not be exposed to the users.
@williamFalcon Do you agree with this ?

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Nov 15, 2020 •
edited
Loading

rank_zero_only is only for internal use and should not be exposed to the users.

@tchaton why not? If someone wants to build a custom logger, I believe it will be useful. BTW some info about rank_zero_log is already given in the logs just above. Added same for rank_zero_experiment.

@Borda Borda modified the milestones: 1.0.x, 1.1 Nov 18, 2020
@rohitgr7 rohitgr7 requested a review from tchaton November 19, 2020 19:28
awaelchli
awaelchli reviewed Nov 22, 2020
View reviewed changes
rohitgr7
rohitgr7 commented Nov 22, 2020
View reviewed changes
@rohitgr7 rohitgr7 requested a review from awaelchli November 22, 2020 13:36
@Borda Borda modified the milestones: 1.1, 1.1.x Nov 30, 2020
@Borda Borda added the ready PRs ready to be merged label Nov 30, 2020
@rohitgr7 rohitgr7 merged commit ef762a0 into master Dec 1, 2020
@rohitgr7 rohitgr7 deleted the docs/logging_docs branch December 1, 2020 06:05
@Borda Borda modified the milestones: 1.1.x, 1.1 Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@nateraw nateraw Awaiting requested review from nateraw

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@awaelchli awaelchli Awaiting requested review from awaelchli

+2 more reviewers

@ydcjeff ydcjeff ydcjeff approved these changes

@s-rog s-rog s-rog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation related logger Related to the Loggers ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.1

Development

Successfully merging this pull request may close these issues.

Trainer's fit method fails when the only logger is the custom logger from the official documentation

8 participants

@rohitgr7 @edenlightning @awaelchli @tchaton @justusschock @ydcjeff @s-rog @Borda