Skip to content

Conversation

@carmocca
Copy link
Contributor

What does this PR do?

Fixes warning appearing with an empty log_dir

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • [n/a] Did you make sure to update the documentation with your changes?
  • [n/a] Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #4419 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4419   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         111     111           
  Lines        8064    8064           
======================================
- Hits         7485    7474   -11     
- Misses        579     590   +11     

@rohitgr7 rohitgr7 merged commit ce261e4 into Lightning-AI:master Oct 29, 2020
@ydcjeff ydcjeff added the bug Something isn't working label Oct 29, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Oct 29, 2020
@carmocca carmocca deleted the bug/wrong-warning branch October 29, 2020 21:58
Borda pushed a commit that referenced this pull request Nov 4, 2020
Co-authored-by: Jeff Yang <[email protected]>
(cherry picked from commit ce261e4)
@carmocca carmocca self-assigned this Nov 1, 2023
@mergify mergify bot added the ready PRs ready to be merged label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants