Add individuals to Metrics in CODEOWNERS #4413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddykoker
requested review from
Borda,
SeanNaren,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton and
williamFalcon
as code owners
ananyahjha93
approved these changes
Oct 28, 2020
Contributor
|
What happens if you are now both in * and in metrics, you get 2x notifications? 🤣 |
Contributor
Author
Not sure, maybe eventually we can remove people from * and have everyone cover different parts |
SeanNaren
approved these changes
Oct 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #4413 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8060 8123 +63
======================================
+ Hits 7481 7543 +62
- Misses 579 580 +1 |
Borda
pushed a commit
that referenced
this pull request
Nov 4, 2020
* ananyahjha93 and teddykoker to codeowners for metrics * add Justus Co-authored-by: Sean Naren <[email protected]> (cherry picked from commit 41de453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add myself and @ananyahjha93 to
CODEOWNERSfor metrics. I recommend others do the same for other portions of the library.