Update docs for num_sanity_val_steps #4343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
Borda,
SeanNaren,
ananyahjha93,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4343 +/- ##
=======================================
+ Coverage 91% 93% +2%
=======================================
Files 111 111
Lines 8258 8011 -247
=======================================
- Hits 7549 7452 -97
+ Misses 709 559 -150 |
Borda
approved these changes
Oct 25, 2020
Borda
changed the title
Borda
force-pushed
the
docs/sanity-val-steps
branch
from
ab305af to
a943bb5
Compare
Contributor
|
why did we drop the xla docs? |
Contributor
Author
|
hmm, is it supposed to be there in this section? It looks like it is misplaced, and the same code sample can be found further down in the tpu_cores section |
tchaton
approved these changes
Oct 27, 2020
ydcjeff
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Not sure if this is needed.
Close the PR if you think it is not necessary.
Fixes #3377
Adds the requested note for the validation dataloder that gets reset during num_sanity_val_steps one extra time.