-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Doc] Fix on_train_batch_end description #4330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4330 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8085 8063 -22
======================================
- Hits 7486 7472 -14
+ Misses 599 591 -8 |
rohitgr7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls wait. a few more are there I think
|
|
I think it is because I added it retrospectively? |
What does this PR do?
I believe the outputs arg to on_train_batch_end hook is the result of training_step_end(training_step(x)) not validation_step_end(validation_step(x)). This PR fixes this in the docstring.
Fixes #4329
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃